Open
Conversation
BSd3v
requested review from
T4rk1n,
emilykl,
gvwilson and
ndrezn
as code owners
gvwilson
approved these changes
Sep 9, 2025
gvwilson
added
infrastructure
Contributor
|
@T4rk1n this looks good to me - please merge when you're next doing a patch |
Contributor
|
@T4rk1n could you take a look and see if this is still good to merge? |
T4rk1n
reviewed
Jan 12, 2026
| ) | ||
|
|
||
| cmdstr = f"npx lerna exec --concurrency {concurrency} --scope='{source_glob}' -- npm {install_type}" | ||
| cmdstr = f"npx lerna exec --concurrency {concurrency} --scope={source_glob} -- npm {install_type}" |
Contributor
There was a problem hiding this comment.
We needed those '' for spaces that might be in the directory path, while ' is not windows compatible, " is and work on both os.
Contributor
Author
There was a problem hiding this comment.
Just tried it, and it did not work.
Contributor
Author
There was a problem hiding this comment.
It was an issue with the posix, needed to be passed True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the upgrade of lerna, windows ceased to build: